fix: equation input undo regession #3923
Conversation
2. feat: add equation and inline-equation elements in editor and slashmenu
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for adding the UI! |
apps/www/src/registry/default/components/editor/use-create-editor.ts
Outdated
Show resolved
Hide resolved
| @@ -79,9 +78,6 @@ export const useEquationInput = ({ | |||
| } else if (isHotkey('escape')(e)) { | |||
| e.preventDefault(); | |||
| onDismiss(); | |||
| } else if (isHotkey('meta+z')(e)) { | |||
| e.preventDefault(); | |||
| editor.undo(); | |||
| } else if (isHotkey('meta+y')(e) || isHotkey('meta+shift+z')(e)) { | |||
There was a problem hiding this comment.
seems not work in macos cmd + shift + z
There was a problem hiding this comment.
hmm, what's the expected behavior for cmd shift z in macos?
There was a problem hiding this comment.
If you really need to do this, you can use Hotkeys.isUndo and Hotkeys.isRedo from packages/core/src/lib/utils/hotkeys.ts.
There was a problem hiding this comment.
I was careless yesterday and did not see the redo logic below 😥, i think simply deleting it makes the most sense?
There was a problem hiding this comment.
The effect looks great. @wststone
There was a problem hiding this comment.
but I found an another history issue.
history issue is really tricky.
focus.mp4
There was a problem hiding this comment.
Referring to Notion, I think what we need to do is to avoid opening the popover during an undo action.
There was a problem hiding this comment.
I will take a look
🦋 Changeset detectedLatest commit: 4c26908 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… menu to prevent autoclose
…r should regain focus.
| @@ -19,36 +19,7 @@ export const DropdownMenu = DropdownMenuPrimitive.Root; | |||
|
|
|||
| export const DropdownMenuTrigger = DropdownMenuPrimitive.Trigger; | |||
|
|
|||
| export const DropdownMenuGroup = React.forwardRef< | |||
Fix regression of #3852, I basically just deleted the handle check of the
meta+zkeydown event and let the native event handles the undo behavior.Also added equation and inline-equation elements to the www editor and slashmenu, so there's more showcasing and also i can test locally.
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changeset